I think that out of everything I've seen mentioned in this or similar threads, Harry Potter would be an absolute smash hit mega seller.
I know I'm a broken record but I'd seriously buy two or three LEs/CEs of a JJP Man of Steel or even Justice League (in a few years after the movies are done) pin; or anything with Superman really.
Other themes that I would like: Guardians of the Galaxy, Princess Bride, Willow, Goonies, Neverending Story, Labyrinth, Predator, Doom (may be better without an LCD screen), Queen, Space Balls, Monty Python Holy Grail.
The Beatles don't do a lot for me and good luck getting the license but I am sure it would be a huge hit.
I'm not sure I can imagine a 007 JJP pin. It seems difficult to mix all of the different eras and actors. Bond is great and I know this is one of the longest running franchises ever but I can't imagine it being a good pin, especially with video on a JJP pin.
Toy Story? Muppets? Heck no. No kid's cartoon or puppet themes, please.