Photo: robin
  1. » Forum
  2. » All Pinside
  3. » Bugs
  4. » If an uploaded image has an apostrophe in it, it disappears
(Topic ID: 127704)

If an uploaded image has an apostrophe in it, it disappears

By ForceFlow

8 years ago



Topic Stats

  • 10 posts
  • 4 Pinsiders participating
  • Latest reply 8 years ago by robin
  • No one calls this topic a favorite

You

Linked Games

No games have been linked to this topic.

    Topic Gallery

    View topic image gallery

    usa-football
    SafariScreenSnapz041.png
    SafariScreenSnapz040.png
    burns-double-quote-
    burns-single-quote-'.png
    0
    0
    0
    #1 8 years ago
    OP
     
    ---

    ForceFlow

    Pinside Moderator

    9y 238K 31,359 268 14

    If I upload an image with an apostrophe in the filename, insert it into the post, and publish the post, the image disappears and seems to get deleted. The image tag with the image number remains behind in the post as raw text.

    0
    0
    0
    #2 8 years ago
     
    AJO

    aobrien5

    Pinside member

    US Highland, IN

    11y 90,300 3,974 5 8

    It'll be fixed in the next version.

    2 weeks later
    0
    0
    0
    #3 8 years ago
     
    JSN

    jfesler

    Pinside member

    9y 92,050 1,793 19 11

    burns-single-quote-'.pngburns-single-quote-'.png burns-double-quote-".pngburns-double-quote-".png
    0
    0
    0
    #4 8 years ago
     
    JSN

    jfesler

    Pinside member

    9y 92,050 1,793 19 11

    Looks like the uploads and displays work, but the preview didn't on the double quote.

    SafariScreenSnapz040.pngSafariScreenSnapz040.png

    0
    0
    0
    #5 8 years ago
     
    JSN

    jfesler

    Pinside member

    9y 92,050 1,793 19 11

    Robin, looks like several cases of double quotes not being escaped during the preview.
    They interfere with the HTML quotes.

    Simplest way to reproduce: upload an image named double-quotes".png

    Single quotes is fine (no surprise, no conflict with the HTML double-quotes).

    SafariScreenSnapz041.pngSafariScreenSnapz041.png
    0
    0
    0
    #6 8 years ago
     
    AJO

    aobrien5

    Pinside member

    US Highland, IN

    11y 90,300 3,974 5 8

    Safari only? both pics showed up fine for me in FF.

    0
    0
    0
    #7 8 years ago
     
    JSN

    jfesler

    Pinside member

    9y 92,050 1,793 19 11

    Safari, Chrome, and Firefox.

    Preview only. The posted images are fine. Just the preview fails.

    0
    0
    0
    #8 8 years ago
     
    JSN

    jfesler

    Pinside member

    9y 92,050 1,793 19 11

    To reproduce,

    Start a comment on this thread.

    Attach an image with " in the filename.

    Hit preview.

    You don't actually have to post the comment to see the failure; posting actually is fine.

    0
    0
    0
    #9 8 years ago
     
    AJO

    aobrien5

    Pinside member

    US Highland, IN

    11y 90,300 3,974 5 8

    ahh, gotcha.

    0
    1
    1
    #10 8 years ago
     
    RVM

    robin

    Pinside founder

    NL Alkmaar

    21y 192K 7,920 94

    usa-football"quote".jpgusa-football"quote".jpg

    Fixed this by urlencoding filenames in post preview.

    Reply

    Wanna join the discussion? Please sign in to reply to this topic.

    Hey there! Welcome to Pinside!

    Donate to Pinside

    Great to see you're enjoying Pinside! Did you know Pinside is able to run without any 3rd-party banners or ads, thanks to the support from our visitors? Please consider a donation to Pinside and get anext to your username to show for it! Or better yet, subscribe to Pinside+!

    This page was printed from https://pinside.com/pinball/forum/topic/if-an-uploaded-image-has-an-apostrophe-in-it-it-disappears and we tried optimising it for printing. Some page elements may have been deliberately hidden.

    Scan the QR code on the left to jump to the URL this document was printed from.