Is there something wrong with it or do you just feel it is incorrect?

Looks good to me as long as you have ground and one or two 30v wires going to the kicker coil, which it's hard to tell, but it seems you do. If so, your wiring looks fine. That switch is there to detect when the ball is in the outhole. Looks a lot cleaner than a lot of things I have seen.

I would leave it be and if you're experiencing a problem, it's likely not there. All the wiring is original besides those extension wires which were replaced or the original wires were cut way too short. I don't think it looks very amateur, not original yes, but I mean there's not many better solution for what they were trying to do besides shrink tubing and soldering the extension wires to the old wires - those metal "bridges" almost look original but that is unlikely.

Looks to me like a "fix" and not a hack. Not many ways to make it better. If it's working, leave it be and enjoy the game IMO. If not, it doesn't appear to be a problem so I would bet it lies elsewhere.

I would assume it completes the path to the "Press Right Flipper To Shoot Ball" light under the apron. The wiring colors even match and on top of that are even bundled together. Perhaps you're missing a switch that ties into the 30v side of things to tell the machine the ball has drained/is in the outhole?

Hmm, okay, with the edited post... moving on.

Does it work? You never clarified this, I'm assuming not? Or are you just concerned?

I could have sworn that after you said that and looking at it again that it does control the apron light and that a separate switch would control the solenoid side of things. The best bet now is probably to wait for a Pinside to verify if this isn't the case and the light is always on regardless if the ball is in the outhole or not.

Looks like he did a barbaric attempt to fix that issue you had when you hooked it back up. Good that you got rid of that mess.

That sounds to be like a stuck outhole switch, and possibly stuck right flipper switch, which is used to kick the ball out but only when detected in the outhole - so the outhole switch or relay would need to be stuck to make the flipper switch even relevant to the problem.

Can you locate your outhole relay and post a picture of it?

Turn the machine off/unplug it and press on the plastic plate on this relay by hand (actuating it by hand). Do any of the switches touch both when actuated and not actuated, or do any of the switches not touch during when actuated and not actuated? (No change between pushing and not pushing is what we're looking for, regardless if both are closed or not closed)